-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console monitor): Log level can be set via program arg #4476
Merged
paullatzelsperger
merged 17 commits into
eclipse-edc:main
from
rafaelmag110:set_monitor_log_level
Sep 24, 2024
Merged
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
a96ab1d
Enable log level configuration via program argument
rafaelmag110 76c4519
use default log level in ExtensionLoaderTest
rafaelmag110 3bfd406
ConsoleMonitor can set log from config value
rafaelmag110 b59ef62
Adjustments
rafaelmag110 f8e647a
checkstyle
rafaelmag110 6835e57
fixed setting precedence
rafaelmag110 3d734ac
Removed changes to BaseRuntime
rafaelmag110 638be6a
Change behavior when wrong level is provided.
rafaelmag110 73f5085
Removed equals and hashcode from ConsoleMonitor
rafaelmag110 0c4ab18
Removed unused bits.
rafaelmag110 363a434
Removed other bits.
rafaelmag110 d8d26ca
nits
rafaelmag110 0f7bc42
suggestion
rafaelmag110 3b1253a
nits
rafaelmag110 aa0c624
It wasn't a nit after all
rafaelmag110 bacc49a
Changed to MethodSource
rafaelmag110 2d4f042
Revert "Changed to MethodSource"
rafaelmag110 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also test various combinations of spaces, upper, lower case etc.:
"--log-level = INFO"
,"--log-level= INFO"
,"--log-level =INFO"
,"--log-level=info"
,...This could also be done with a
ParamterizedTest
and a@ValueSource
.Not saying all of these variants should get accepted, IMO it's fine to only accept
"--log-level=XYZ"
, but to have a definitive test and to guard against regression.