feat: introduces dymanic feature binding in WebService #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
added
enhancement
wolf4ood
force-pushed
the
refactor/4558_dsp_json_ld_configuration
branch
3 times, most recently
from
0533195 to
aca1429
Compare
wolf4ood
requested review from
paullatzelsperger,
ronjaquensel,
juliapampus and
ndr-brt
as code owners
wolf4ood
force-pushed
the
refactor/4558_dsp_json_ld_configuration
branch
from
997826a to
5ae3845
Compare
wolf4ood
force-pushed
the
refactor/4558_dsp_json_ld_configuration
branch
from
5ae3845 to
01a82b3
Compare
ndr-brt
reviewed
Oct 18, 2024
| transformerRegistry.register(new JsonObjectFromProtocolVersionsTransformer()); | ||
| transformerRegistry.register(new JsonObjectFromVersionsError(Json.createBuilderFactory(Map.of()))); | ||
|
|
||
| webService.registerResource(ApiContext.PROTOCOL, new DspVersionApiController(requestHandler, service)); | ||
| webService.registerDynamicResource(ApiContext.PROTOCOL, DspVersionApiController.class, new JerseyJsonLdInterceptor(jsonLd, jsonLdMapper, DSP_SCOPE_V_08)); |
There was a problem hiding this comment.
version endpoint has been introduced in version 2024/1 so it should have the related namespace (as pointed from the documentation: https://docs.internationaldataspaces.org/ids-knowledgebase/dataspace-protocol/common-functionalities/common.protocol)
not sure on what should happen with the next version tho...
There was a problem hiding this comment.
The version endpoint actually cannot have a version and it should change in the future i think.
but we currently use 0.8 namespace for terms , that's why I binded it to 0.8
There was a problem hiding this comment.
If we are ok to do the "breaking change" we can do it once we introduce 2024/1 as namespace
ndr-brt
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Introduces dymanic feature binding in WebService for binding a
JerseyJsonLdInterceptorfor each controller in order to use the right JSON-LD scope.Additionally the
JsonLdRemoteMessageSerializerImpluses the right scope based on the protocol version.Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #4558
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.