feat: add JTI validation feature #4560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
3749_jti_validation_service
branch
3 times, most recently
from
146e4f6 to
872bccf
Compare
paullatzelsperger
requested review from
wolf4ood and
ndr-brt
and removed request for
ndr-brt
paullatzelsperger
force-pushed
the
3749_jti_validation_service
branch
from
872bccf to
a2c1b88
Compare
wolf4ood
approved these changes
Oct 21, 2024
...ql/src/test/java/org/eclipse/edc/edr/store/index/sql/SqlJtiValidationStoreExtensionTest.java
Outdated
Show resolved
Hide resolved
…java/org/eclipse/edc/edr/store/index/sql/SqlJtiValidationStoreExtensionTest.java Co-authored-by: Enrico Risa <enrico.risa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
adds a feature to validate the uniqueness of Token-IDs ("jti"). To do that, a
JtiValidationStoreclass was implemented (in-mem + SQL) that holds valid JTI strings and is cleaned up periodically by a reaper thread.Store implementations for in-mem and SQL were added.
Why it does that
to be able to validate JTI claims
Further notes
token-coremodule should be split up into atoken-core(containing the extension) and atoken-libmodules (containing the rules, in-mem store, and other impls etc.). This will come in a subsequent PR (Remove references tocore:common:token-core#4389), I didn't want to blow the changeset up even more.EmbeddedSecureTokenService, but are validated in theAccessTokenVerifierImplof IdentityHub. A related PR will be created shortly.Linked Issue(s)
Closes #3749
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.