Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: initialize store at manager build #710

Merged
merged 1 commit into from
Feb 18, 2022
Merged

core: initialize store at manager build #710

merged 1 commit into from
Feb 18, 2022

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Feb 18, 2022

Follow up of #690 .
Since we decided to change the lock implementation as decided in #690, and given that there was a test that persisted to fail on github action (but it passed on my machine) I decided to extract the only feature it remained in that PR

What brings

Currently, on the managers (TransferProcess and ContractNegotiation) the store object is injected on the "start" method invocation. Since there are no reasons to do that, I added a store method on the builders and make it as a mandatory field on the managers.

@codecov-commenter
Copy link

Codecov Report

Merging #710 (b911a18) into main (1f62003) will increase coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #710   +/-   ##
=========================================
  Coverage     56.37%   56.37%           
  Complexity     2088     2088           
=========================================
  Files           585      585           
  Lines         13012    13021    +9     
  Branches        925      925           
=========================================
+ Hits           7335     7341    +6     
- Misses         5255     5258    +3     
  Partials        422      422           
Impacted Files Coverage Δ
...ceconnector/contract/ContractServiceExtension.java 0.00% <0.00%> (ø)
...connector/transfer/core/CoreTransferExtension.java 0.00% <0.00%> (ø)
...iation/ConsumerContractNegotiationManagerImpl.java 60.97% <100.00%> (+0.27%) ⬆️
...iation/ProviderContractNegotiationManagerImpl.java 64.03% <100.00%> (+0.28%) ⬆️
...sfer/core/transfer/TransferProcessManagerImpl.java 51.64% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f62003...b911a18. Read the comment docs.

@jimmarino jimmarino merged commit 0a331f7 into eclipse-edc:main Feb 18, 2022
Izzzu pushed a commit to agera-edc/DataSpaceConnector that referenced this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants