feat: Add flexibility to modify the base-href of DataDashboard app #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
The Dockerfile and app-config.service.ts file.
Why it does that
These changes add flexibility to modify the
base-hrefof the application according to need.For example, when we try to deploy the edc-datadashboard to a Kubernetes cluster and implement an ingress route to access the services, it cannot load the asset files (css, js, images) properly. As a result, the angular app cannot be loaded properly.
In this PR, the
buildcommand in theDockerfilehas been modified, which uses aBASE_PATHargument. We can pass theBASE_PATHof choice at the time of image creation.Also, the
app-config.service.tsfile is using the url 'assets/config/app.config.json' to get app config files.In case, we are using a
base-hrefdifferent than root (‘/’) then this will fail to get the files. Therefore, we modified this file and prepared the url by adding thebase-hrefwith it.Further notes
Applications that are using the Dockerfile of DataDashboard, should pass a BASE_PATH at the image creation time.
Linked Issue(s)
Closes #224