Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds transfer multiple S3 objects functionality #104

Merged
merged 6 commits into from
Oct 10, 2023
Merged

feat: adds transfer multiple S3 objects functionality #104

merged 6 commits into from
Oct 10, 2023

Conversation

yurimssilva
Copy link
Contributor

What this PR changes/adds

  • This PR introduces enhancements to the S3 Transfer Extension, enabling the transfer of multiple S3 objects simultaneously. It adds support for the keyPrefix property in the DataAddress configuration, which allows users to specify a prefix for grouping and transferring related objects in an Amazon S3 bucket.

Why it does that

  • The change improves efficiency when transferring related S3 objects, aligning with Amazon S3 data organization standards. The new keyPrefix property streamlines multiple object transfers, reducing overhead.

Further notes

  • Added the keyPrefix property to the DataAddress configuration for AmazonS3 transfers.
  • Validated and tested the behavior of object transfers with and without keyPrefix.
  • Introduced a note in the documentation to explain new behavior.

Linked Issue(s)

Closes #103

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

@ndr-brt ndr-brt self-requested a review October 6, 2023 12:42
…into feature/s3_multiple_objects_transfer

# Conflicts:
#	extensions/data-plane/data-plane-aws-s3/src/main/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSource.java
@yurimssilva yurimssilva requested a review from ndr-brt October 9, 2023 13:05
@yurimssilva yurimssilva marked this pull request as ready for review October 9, 2023 13:19
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d030ae7) 78.19% compared to head (ed65528) 80.29%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   78.19%   80.29%   +2.09%     
==========================================
  Files          19       19              
  Lines         454      477      +23     
  Branches       13       15       +2     
==========================================
+ Hits          355      383      +28     
+ Misses         98       92       -6     
- Partials        1        2       +1     
Files Coverage Δ
...pse/edc/connector/dataplane/aws/s3/S3DataSink.java 96.29% <100.00%> (ø)
.../connector/dataplane/aws/s3/S3DataSinkFactory.java 100.00% <ø> (ø)
...onnector/dataplane/aws/s3/S3DataSourceFactory.java 100.00% <100.00%> (ø)
...e/edc/connector/dataplane/aws/s3/S3DataSource.java 82.60% <95.45%> (+36.77%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurimssilva yurimssilva requested a review from ndr-brt October 9, 2023 15:36
@ndr-brt ndr-brt added the enhancement New feature or request label Oct 10, 2023
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good! I think the format of the years in the headers is not correct... it should be 2022 - 2023 and not 2022-2023.
As soon as the checks are green, I will merge this.

@ndr-brt ndr-brt merged commit cd7e6bd into eclipse-edc:main Oct 10, 2023
14 checks passed
@yurimssilva yurimssilva deleted the feature/s3_multiple_objects_transfer branch February 6, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Transfer Multiple S3 Objects Functionality to Aws S3 Data Plane module
3 participants