-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds transfer multiple S3 objects functionality #104
feat: adds transfer multiple S3 objects functionality #104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.
...data-plane-aws-s3/src/main/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSource.java
Outdated
Show resolved
Hide resolved
...data-plane-aws-s3/src/main/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSource.java
Outdated
Show resolved
Hide resolved
...data-plane-aws-s3/src/main/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSource.java
Outdated
Show resolved
Hide resolved
...-plane-aws-s3/src/test/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSourceTest.java
Outdated
Show resolved
Hide resolved
…into feature/s3_multiple_objects_transfer # Conflicts: # extensions/data-plane/data-plane-aws-s3/src/main/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSource.java
extensions/common/aws/aws-s3-core/src/main/java/org/eclipse/edc/aws/s3/S3BucketSchema.java
Outdated
Show resolved
Hide resolved
...data-plane-aws-s3/src/main/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSource.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 78.19% 80.29% +2.09%
==========================================
Files 19 19
Lines 454 477 +23
Branches 13 15 +2
==========================================
+ Hits 355 383 +28
+ Misses 98 92 -6
- Partials 1 2 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good! I think the format of the years in the headers is not correct... it should be 2022 - 2023
and not 2022-2023
.
As soon as the checks are green, I will merge this.
What this PR changes/adds
keyPrefix
property in theDataAddress
configuration, which allows users to specify a prefix for grouping and transferring related objects in an Amazon S3 bucket.Why it does that
Further notes
keyPrefix
property to theDataAddress
configuration for AmazonS3 transfers.keyPrefix
.Linked Issue(s)
Closes #103