feat: configurable chunk size #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change chuck size from bytes to mb Add ReadMe
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.
git-masoud
changed the title
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
- Coverage 80.29% 80.16% -0.13%
==========================================
Files 19 19
Lines 477 484 +7
Branches 15 17 +2
==========================================
+ Hits 383 388 +5
- Misses 92 93 +1
- Partials 2 3 +1
☔ View full report in Codecov by Sentry. |
ndr-brt
requested changes
Oct 26, 2023
...ne-aws-s3/src/main/java/org/eclipse/edc/connector/dataplane/aws/s3/DataPlaneS3Extension.java
Outdated
Show resolved
Hide resolved
...e/data-plane-aws-s3/src/main/java/org/eclipse/edc/connector/dataplane/aws/s3/S3DataSink.java
Outdated
Show resolved
Hide resolved
…ze in initialization of s3-dataplane.
ndr-brt
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Chunk size can be configured via the EDC configuration.
Why it does that
Currently, the chunk size in the data sink is hard coded to 500MB as CHUNK_SIZE_IN_BYTES. This could limit users in particular environments with constrained memory resources.
Linked Issue(s)
Closes #112