Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix broken links #146

Merged
merged 4 commits into from Nov 24, 2023
Merged

chore: fix broken links #146

merged 4 commits into from Nov 24, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 23, 2023

What this PR changes/adds

The links in the main readme were updated as they were broken. To fix some broken links, the docs/developer/decision-records directory had to be created. A readme was placed in the latter to populate the folder.

Why it does that

To make links work again.

Further notes

No further notes.

Linked Issue(s)

No issues was created.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@ndr-brt ndr-brt added the documentation Improvements or additions to documentation label Nov 24, 2023
@ndr-brt
Copy link
Member

ndr-brt commented Nov 24, 2023

please update the dependencies file, then we'll be ready to go

@ghost
Copy link
Author

ghost commented Nov 24, 2023

@ndr-brt I updated the deps file, thanks. Hopefuly this time the workflows are sucessfull!

README.md Outdated Show resolved Hide resolved
Co-authored-by: Julia Pampus <72392527+juliapampus@users.noreply.github.com>
@ghost ghost requested a review from juliapampus November 24, 2023 11:40
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0519c97) 64.54% compared to head (dd4d1b3) 64.54%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #146   +/-   ##
=======================================
  Coverage   64.54%   64.54%           
=======================================
  Files          26       26           
  Lines         629      629           
  Branches       28       28           
=======================================
  Hits          406      406           
  Misses        218      218           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndr-brt
Copy link
Member

ndr-brt commented Nov 24, 2023

@rafaelmagalhaes-ctw stil not working, my suggestion would be to copy and paste the output of the failed job: https://github.com/eclipse-edc/Technology-Aws/actions/runs/6980195692/job/18995724372?pr=146

@ndr-brt ndr-brt merged commit 14a431e into eclipse-edc:main Nov 24, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants