fix: compile errors after EDC token refactor #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
fix/compile_errors
branch
from
e7c651e to
79bc6c8
Compare
ndr-brt
approved these changes
Jan 15, 2024
| @@ -37,7 +34,7 @@ | |||
| * using the AWS Secretes Manager Vault implementation. | |||
| * The extension requires the "edc.vault.aws.region" parameter to be set to the AWS region in which secrets should be stored. | |||
| */ | |||
| @Provides({ Vault.class, PrivateKeyResolver.class, CertificateResolver.class }) | |||
| @Provides({ Vault.class }) | |||
There was a problem hiding this comment.
this can be removed as the @Provider annotation is used
paullatzelsperger
force-pushed
the
fix/compile_errors
branch
from
943a5de to
e557a88
Compare
ndr-brt
approved these changes
Jan 15, 2024
wolf4ood
approved these changes
Jan 15, 2024
paullatzelsperger
force-pushed
the
fix/compile_errors
branch
from
e557a88 to
a16868e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Briefly describe WHAT your pr changes, which features it adds/modifies.
Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists