Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds property secretToken configuration #223

Merged
merged 5 commits into from
Feb 19, 2024
Merged

feat: adds property secretToken configuration #223

merged 5 commits into from
Feb 19, 2024

Conversation

yurimssilva
Copy link
Contributor

What this PR changes/adds

  • Adds property secretToken configuration dedicated to holding the alias for the credentials secret.

Why it does that

  • By doing so, the secret alias would be separate from the object naming, allowing for the utilization of reusable secrets across multiple assets.

Linked Issue(s)

Closes #211

@yurimssilva yurimssilva changed the title Feature/s3 credentials secret feature: s3 credentials secret Feb 6, 2024
@yurimssilva yurimssilva changed the title feature: s3 credentials secret feature: adds property secretToken configuration Feb 6, 2024
@yurimssilva yurimssilva changed the title feature: adds property secretToken configuration feature: adds property secretToken configuration Feb 8, 2024
@yurimssilva yurimssilva self-assigned this Feb 8, 2024
@yurimssilva yurimssilva changed the title feature: adds property secretToken configuration feat: adds property secretToken configuration Feb 8, 2024
@yurimssilva yurimssilva added the enhancement New feature or request label Feb 8, 2024
@yurimssilva yurimssilva requested a review from wolf4ood February 8, 2024 15:24
@yurimssilva yurimssilva marked this pull request as ready for review February 8, 2024 15:26
ndr-brt
ndr-brt requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add some tests that describes the new behavior?

@yurimssilva yurimssilva requested a review from ndr-brt February 15, 2024 15:35
ndr-brt
ndr-brt approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the dependencies check

@ndr-brt ndr-brt merged commit 557d234 into eclipse-edc:main Feb 19, 2024
15 checks passed
@yurimssilva yurimssilva deleted the feature/s3_credentials_secret branch February 19, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndr-brt ndr-brt ndr-brt approved these changes

@wolf4ood wolf4ood Awaiting requested review from wolf4ood

Assignees

@yurimssilva yurimssilva

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Reusable Credentials
2 participants
@yurimssilva @ndr-brt