Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removes StatusChecker #96

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

wolf4ood
Copy link
Contributor

What this PR changes/adds

removes StatusChecker

Why it does that

Removed from EDC core component

Linked Issue(s)

Closes #95

@wolf4ood wolf4ood self-assigned this Sep 28, 2023
@wolf4ood wolf4ood added the enhancement New feature or request label Sep 28, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are always happy to welcome new contributors ❤️ To make things easier for everyone, please make sure to follow our contribution guidelines, check if you have already signed the ECA, and relate this pull request to an existing issue or discussion.

@wolf4ood wolf4ood force-pushed the feat/95_remove_status_checker branch 3 times, most recently from c2f2345 to b1cbe59 Compare September 28, 2023 08:47
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9b1a838) 73.19% compared to head (fc15ade) 78.53%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   73.19%   78.53%   +5.34%     
==========================================
  Files          20       19       -1     
  Lines         485      452      -33     
  Branches       17       13       -4     
==========================================
  Hits          355      355              
+ Misses        129       96      -33     
  Partials        1        1              
Files Coverage Δ
...nector/provision/aws/s3/AwsProvisionExtension.java 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood wolf4ood force-pushed the feat/95_remove_status_checker branch from b1cbe59 to 62fc68b Compare September 28, 2023 08:55
@wolf4ood wolf4ood force-pushed the feat/95_remove_status_checker branch from 62fc68b to fc15ade Compare September 28, 2023 09:12
@wolf4ood wolf4ood merged commit 2bb6d23 into eclipse-edc:main Sep 28, 2023
14 checks passed
@wolf4ood wolf4ood deleted the feat/95_remove_status_checker branch September 28, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the status checker
3 participants