Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable branch protection for OpenMQ releases #8

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Aug 8, 2024

No description provided.

@pzygielo pzygielo requested a review from a team as a code owner August 8, 2024 08:56
Copy link

This is your friendly self-service bot.

Thank you for raising a pull request to update the configuration of your GitHub organization.
You can manually add reviewers to this PR to eventually enable auto-merging.

The following conditions need to fulfilled for auto-merging to be available:

  • valid configuration
  • approved by a project lead
  • does not require any secrets
  • does not update settings only accessible via the GitHub Web UI
  • does not remove any resource
Otterdog commands and options

You can trigger otterdog actions by commenting on this PR:

  • /otterdog team-info checks the team / org membership for the PR author
  • /otterdog validate validates the configuration change
  • /otterdog validate info validates the configuration change, printing also validation infos
  • /otterdog check-sync checks if the base ref is in sync with live settings
  • /otterdog merge merges and applies the changes if the PR is eligible for auto-merging (only accessible for the author)
  • /otterdog done notifies the self-service bot that a required manual apply operation has been performed (only accessible for members of the admin team)
  • /otterdog apply re-apply a previously failed attempt (only accessible for members of the admin team)

Copy link

This is your friendly self-service bot.

The author (pzygielo) of this PR is associated with this organization in the role of MEMBER.

Additionally, pzygielo is a member of the following teams:

Copy link

This is your friendly self-service bot.
Please find below the validation of the requested configuration changes:

Diff for 943562a
Organization ee4j[id=eclipse-ee4j]
╷
│ Warning: repository[name="jersey.github.io"] has 'gh_pages_build_type' with value 'workflow' but no corresponding 'github-pages' environment, please add such an environment.
╵
  there have been 84 validation infos, enable verbose output with '-v' to to display them.

+  add branch_protection_rule[pattern="6.5.x", repository="openmq"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "6.5.x"
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = false
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = false
+    requires_status_checks            = false
+    restricts_pushes                  = false
+  }

+  add branch_protection_rule[pattern="6.4.x", repository="openmq"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "6.4.x"
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = false
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = false
+    requires_status_checks            = false
+    restricts_pushes                  = false
+  }

+  add branch_protection_rule[pattern="6.3.x", repository="openmq"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "6.3.x"
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = false
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = false
+    requires_status_checks            = false
+    restricts_pushes                  = false
+  }

+  add branch_protection_rule[pattern="6.2.x", repository="openmq"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "6.2.x"
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = false
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = false
+    requires_status_checks            = false
+    restricts_pushes                  = false
+  }
  
  Plan: 4 to add, 0 to change, 0 to delete.

Copy link

This is your friendly self-service bot. The current configuration is in-sync with the live settings. 🚀

Copy link

This is your friendly self-service bot.
This Pull Request is eligible for auto-merging as it passed the following checks:

  • valid configuration
  • approved by a project lead
  • does not require any secrets
  • does not update settings only accessible via the GitHub Web UI
  • does not remove any resource

In order to automatically merge and apply the changes, add a comment /otterdog merge. 🚀

@netomi
Copy link
Contributor

netomi commented Aug 8, 2024

LGTM, in case you are not aware, you can merge the change yourself by adding /otterdog merge as comment.

@pzygielo
Copy link
Contributor Author

pzygielo commented Aug 8, 2024

/otterdog merge

@eclipse-otterdog eclipse-otterdog bot merged commit 9136ca0 into eclipse-ee4j:main Aug 8, 2024
3 checks passed
Copy link

This is your friendly self-service bot.

The following changes have been successfully applied:

Organization ee4j[id=eclipse-ee4j]
╷
│ Warning: repository[name="jersey.github.io"] has 'gh_pages_build_type' with value 'workflow' but no corresponding 'github-pages' environment, please add such an environment.
╵
  there have been 84 validation infos, enable verbose output with '-v' to to display them.

+  add branch_protection_rule[pattern="6.5.x", repository="openmq"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "6.5.x"
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = false
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = false
+    requires_status_checks            = false
+    restricts_pushes                  = false
+  }

+  add branch_protection_rule[pattern="6.4.x", repository="openmq"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "6.4.x"
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = false
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = false
+    requires_status_checks            = false
+    restricts_pushes                  = false
+  }

+  add branch_protection_rule[pattern="6.3.x", repository="openmq"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "6.3.x"
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = false
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = false
+    requires_status_checks            = false
+    restricts_pushes                  = false
+  }

+  add branch_protection_rule[pattern="6.2.x", repository="openmq"] {
+    allows_deletions                  = false
+    allows_force_pushes               = false
+    blocks_creations                  = false
+    bypass_force_push_allowances      = []
+    is_admin_enforced                 = false
+    lock_allows_fetch_and_merge       = false
+    lock_branch                       = false
+    pattern                           = "6.2.x"
+    requires_commit_signatures        = false
+    requires_conversation_resolution  = false
+    requires_deployments              = false
+    requires_linear_history           = false
+    requires_pull_request             = false
+    requires_status_checks            = false
+    restricts_pushes                  = false
+  }

  
  Applying changes:


  Done.
  
  Executed plan: 4 added, 0 changed, 0 deleted.

@pzygielo
Copy link
Contributor Author

pzygielo commented Aug 8, 2024

in case you are not aware, you can merge the change yourself by adding /otterdog merge as comment

I was not aware of having that permission.
Thanks.

@pzygielo pzygielo deleted the mqbp branch August 8, 2024 09:19
@netomi
Copy link
Contributor

netomi commented Aug 8, 2024

see #8 (comment)

so the rule "approved by a project lead" is implicit if a project lead creates a PR ofc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants