Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and promote Jakarta Websocket 2.0.0 TCK for JakartaEE 9 release #395

Closed
alwin-joseph opened this issue Jul 30, 2020 · 14 comments
Closed

Review and promote Jakarta Websocket 2.0.0 TCK for JakartaEE 9 release #395

alwin-joseph opened this issue Jul 30, 2020 · 14 comments

Comments

@alwin-joseph
Copy link
Contributor

  1. Complete userguide/documentation changes for Jakarta Websocket TCK.
  2. Review the jakarta-websocket-tck-2.0.0.zip bundle at https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/staged-900/ (or websocket-tck-2.0.0.zip bundle at https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9/nightly) to look for any changes missed to be included in JakartaEE 9 release.
  3. Promote the bundle https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/staged-900/jakarta-websocket-tck-2.0.0.zip to https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/promoted/ by using the job https://ci.eclipse.org/jakartaee-tck/job/promote_jakartaee9_eftl_bundles/.
  4. Remove the boolean parameter (WEBSOCKET_TCK) and comment out the respective wget + if condition in https://ci.eclipse.org/jakartaee-tck/job/promote_jakartaee9_eftl_bundles/configure so that the same bundle is not promoted again.
@edbratt edbratt closed this as completed Aug 5, 2020
@edbratt edbratt reopened this Aug 5, 2020
This was referenced Aug 7, 2020
Merged
Merged
Merged
@gabrielbussolo
Copy link
Contributor

@alwin-joseph can u exemplify what type of changes I can search across jakarta-websocket-tck-2.0.0.zip?
thanks

@scottmarlow
Copy link
Contributor

There may be more version updates than you made in your pull request:

wget https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/staged-900/jakarta-websocket-tck-2.0.0.zip
unzip jakarta-websocket-tck-2.0.0.zip
grep -ril Websocket.*Version.*1.
websocket-tck/docs/staging/rules.html:for Jakarta WebSocket Version 1.1.</p></td>
websocket-tck/docs/staging/intro.html:<p>WebSocket Version: The WebSocket 1.1 TCK
websocket-tck/docs/staging/intro.html:<p>WebSocket TCK version 1.1, which includes:</p>
websocket-tck/docs/staging/install.html:<p>WebSocket TCK version 1.1, which includes:</p>
websocket-tck/docs/assertions/WebSocketJavadocAssertions.html:</font></TD><TD align="left" valign="center"><font size="1PT">Returns the version of the websocket protocol currently being used. This is taken as the value of the Sec-WebSocket-Version header used in the opening handshake. i.e. "13".</font></TD><TD align="center" valign="center"><font size="1PT">true</font></TD><TD align="center" valign="center"><font size="1PT">
websocket-tck/docs/WebSocketTCK1.1-ReleaseNotes.html:<h1>Jakarta WebSocket Technology Compatibility Kit, Version 1.1<br>
websocket-tck/docs/WebSocketTCK1.1-ReleaseNotes.html:<p>The Jakarta WebSocket, Version 1.1 Technology Compatibility Kit (TCK) includes the following items:</p>
websocket-tck/docs/WebSocketTCK1.1-ReleaseNotes.html:     <li><strong>Signature test</strong> that checks that all of the public APIs are supported in the Jakarta WebSocket Version 1.1 implementation that is being tested</li>
websocket-tck/docs/WebSocketTCK1.1-ReleaseNotes.html:<li>Eclipse Compatible Implementation for WebSocket  Version 1.1</li>

I also searched for Java EE and see a lot of that (some of which is in Java sources that are also included in other TCKS (e.g. signature, deployment handling) and a reference to JSR-88 via websocket-tck/src/com/sun/ts/tests/signaturetest/SigTest.java.

A big lesson is that we should update TCK documention earlier in the development process, as some of these references could of been updated globally sooner.

@edbratt
Copy link
Contributor

edbratt commented Aug 10, 2020 via email

@scottmarlow
Copy link
Contributor 

I don't think we should be modifying anything in the signature test
material. OR, maybe differently: we should file an issue and ask Alwin
to look into fixing that.

I opened #420 for any documentation changes that we want to make post EE 9, like the signature test material.

@edbratt edbratt mentioned this issue Sep 2, 2020
Closed
11 tasks
@m0mus
Copy link
Contributor

m0mus commented Sep 14, 2020

@alwin-joseph Can you please re-stage Websocket TCK?

@alwin-joseph
Copy link
Contributor Author

@alwin-joseph Can you please re-stage Websocket TCK?

Done now.

@markt-asf
Copy link
Contributor

@alwin-joseph The TCK that was staged appears to be incomplete. The /dist directory (containing the WARs) is empty.

@alwin-joseph
Copy link
Contributor Author

@alwin-joseph The TCK that was staged appears to be incomplete. The /dist directory (containing the WARs) is empty.

I see it now. Let me fix it and restage.

@alwin-joseph
Copy link
Contributor Author

@alwin-joseph The TCK that was staged appears to be incomplete. The /dist directory (containing the WARs) is empty.

I see it now. Let me fix it and restage.

I have restaged the websocket tck now at https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/staged-900/jakarta-websocket-tck-2.0.0.zip after the fix. Thanks for pointing the issue.

@markt-asf
Copy link
Contributor

Thanks for the updated TCK. I've downloaded and run it successfully against Apache Tomcat 10. I skimmed the documentation very quickly. I didn't notice any major issues although the number of tests in the release notes looks wrong (I see 731 + 2 skipped + 1 signature = 734 in total).

@alwin-joseph
Copy link
Contributor Author

Thanks for the updated TCK. I've downloaded and run it successfully against Apache Tomcat 10. I skimmed the documentation very quickly. I didn't notice any major issues although the number of tests in the release notes looks wrong (I see 731 + 2 skipped + 1 signature = 734 in total).

This was updated and the TCK refreshed at https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/staged-900/jakarta-websocket-tck-2.0.0.zip. Please let us know if any more changes required for the websocket TCK. If not shall we proceed to promote it to https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/promoted/jakarta-websocket-tck-2.0.0.zip?

@markt-asf
Copy link
Contributor

Looks good to me.

@edbratt
Copy link
Contributor

edbratt commented Sep 23, 2020

Please promote the current staged WebSocket TCK.

@alwin-joseph
Copy link
Contributor Author

Please promote the current staged WebSocket TCK.

Done. websocket tck is now available at https://download.eclipse.org/ee4j/jakartaee-tck/jakartaee9-eftl/promoted/jakarta-websocket-tck-2.0.0.zip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@scottmarlow @gabrielbussolo @markt-asf @m0mus @edbratt @alwin-joseph