Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating user guide to Websocket TCK 2.0 #414

Merged
merged 11 commits into from
Aug 16, 2020
Merged

Updating user guide to Websocket TCK 2.0 #414

merged 11 commits into from
Aug 16, 2020

Conversation

gabrielbussolo
Copy link
Contributor

@gabrielbussolo gabrielbussolo commented Aug 7, 2020 •
edited
Loading

Hey, folks, I'm working at issue #395

ps: I'm leaving it as a draft so the task progress can be tracked and errors and suggestions can be reviewed earlier

@gabrielbussolo
Updating attributes.conf to Websocket TCK 2.0
e8c87ea 
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
@gabrielbussolo
Updating title.adoc to Websocket TCK 2.0
2d7959d 
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
@scottmarlow
Copy link
Contributor

scottmarlow commented Aug 7, 2020 •
edited
Loading

Thanks @gabrielbussolo, I will start looking now.

Please also change src/main/jbake/content/config.adoc:
Eclipse EE4J Jakarta EE 8 Compatible Implementation
To:
Jakarta EE 8 Compatible Implementation

There are also 5 references to Java EE (some followed by 8). Please do replace these with Jakarta EE and the 8 that follows should be replaced with 9.

@gabrielbussolo
Updating version at pom.xml
a210736 
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
@gabrielbussolo
Updating version GlassFish version and Jakarta at config.adoc and con…
d44838f 
…fig.inc

Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
@gabrielbussolo
Isolating platforms.inc from intro.adoc
2ebbd01 
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
@gabrielbussolo
Updating Jakarta version at install-server.inc
aebd760 
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
@gabrielbussolo
Updating year at footer.ftl
4913660 
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
@gabrielbussolo
Updating faq.adoc
0a5f84b 
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
@gabrielbussolo
Updating packages version at tck-packages.inc
8e26cdd 
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
@gabrielbussolo
Updating to Jakarta EE 9
cd2756c 
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
@gabrielbussolo gabrielbussolo marked this pull request as ready for review August 7, 2020 22:03
@gabrielbussolo gabrielbussolo mentioned this pull request Aug 10, 2020
Merged
@gabrielbussolo
Updating TCKPackageName for Websocket 2.0 user guide
a66880e 
Signed-off-by: Gabriel Bussolo <contact@gabrielbussolo.dev>
alwin-joseph
alwin-joseph approved these changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@alwin-joseph alwin-joseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alwin-joseph alwin-joseph merged commit b601561 into jakartaee:master Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alwin-joseph alwin-joseph alwin-joseph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielbussolo @scottmarlow @alwin-joseph