Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #1756 #1766

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Fixes for #1756 #1766

merged 4 commits into from
Oct 9, 2023

Conversation

laurentschoelens
Copy link
Contributor

Fixes #1756

Documentation is now handled seperatly from BindInfo to avoid regression
Auto-ack is only done on presence of auto-acknowledge tag in binding files, auto-generated for episode files.

@@ -41,19 +41,9 @@
import com.sun.tools.xjc.reader.xmlschema.bindinfo.BindInfo;
import com.sun.tools.xjc.util.CodeModelClassFactory;
import com.sun.tools.xjc.util.ErrorReceiverFilter;
import com.sun.xml.xsom.*;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use single class imports, please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and fixed IDE config 😄

Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit 731a5f0 into eclipse-ee4j:master Oct 9, 2023
4 checks passed
lukasj pushed a commit to lukasj/jaxb-ri that referenced this pull request Oct 9, 2023
* Fixes issues introduced in eclipse-ee4j#1734 (NPE / auto-ack on non wanted classes)
* Fixing issues eclipse-ee4j#1756 (for eclipse-ee4j#1734 PR)

(cherry picked from commit 731a5f0)
lukasj pushed a commit that referenced this pull request Oct 13, 2023
* Fixes issues introduced in #1734 (NPE / auto-ack on non wanted classes)
* Fixing issues #1756 (for #1734 PR)

(cherry picked from commit 731a5f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues due to #1734 #1746
2 participants