-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for #1756 #1766
Fixes for #1756 #1766
Conversation
@@ -41,19 +41,9 @@ | |||
import com.sun.tools.xjc.reader.xmlschema.bindinfo.BindInfo; | |||
import com.sun.tools.xjc.util.CodeModelClassFactory; | |||
import com.sun.tools.xjc.util.ErrorReceiverFilter; | |||
import com.sun.xml.xsom.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use single class imports, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, and fixed IDE config 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fixes issues introduced in eclipse-ee4j#1734 (NPE / auto-ack on non wanted classes) * Fixing issues eclipse-ee4j#1756 (for eclipse-ee4j#1734 PR) (cherry picked from commit 731a5f0)
Fixes #1756
Documentation is now handled seperatly from BindInfo to avoid regression
Auto-ack is only done on presence of
auto-acknowledge
tag in binding files, auto-generated for episode files.