Fix issue #1819 incorrect enum value name generation with leading digits #1821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any character complying with
isJavaIdentifierPart
but notisJavaIdentifierStart
(e.g. digits) at the beginning of the name of an enum value will makebuildCEnumConstants
return null (asisJavaIdentifier
fails) which causes the enums values to be namedVALUE_x
(method is called again but withneedsToGenerateMemberName
).This PR fixes that by checking whether the first character of an enum value name complies with
isJavaIdentifierStart
, if not an underscore will be added to theStringBuilder
that builds the name of the value. As that check is executed before the normal name generation loop that underscore is the first char of theStringBuilder
and acts a prefix to the name. That behavior is consistent with the one found in other places of the java code generation, for example a package called12
will be renamed to_12
.Note: There was a typo in an earlier version of this PR