-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PathProvider supports Path entities, in preparation for future default support in JAX-RS 4.1 / Jersey 4.1 #5674
Conversation
@jansupol Kindly asking for adoption of this optional feature to Jersey 3.1.8 and Jersey 4.0, so we have an existing technical base to decide adoption of |
924c585
to
6382438
Compare
@jansupol Jenkins says that all tests run fine on JDK 21, but on JDK 11 fails with the below message. I doubt that it is caused by my changes / this PR. But how to proceed now?
|
…t support in JAX-RS 4.x / Jersey 4.x. Signed-off-by: Markus KARG <markus@headcrashing.eu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @mkarg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for adopting this into upcomging 3.1.8. Please find the proposed JAX-RS enhancement proposal here: jakartaee/rest#1274. :-) |
Kindly asking your vote for jakartaee/rest#1275. :-) |
Aim
This PR adds support for
Path
entity types in analogy to the existing support forFile
entity types.Justification
In an attempt to modernize JAX-RS and better align it with modern Java, I soon will file a PR for Jakarta REST 4.1 to natively support
Path
entity types by all compliant implementations. As an existing implementation is needed before making an API change part of the specification and TCK, I kindly ask to adopt this new feature to Jersey 3.1 already (as it is optional and non-breaking).Description
This PR only adds optional support for
Path
, not making it part ofMessagingBinders
as it is not yet a mandatory element of the JAX-RS specification, neither in 3.x nor 4.0. In a subsequent PR on the4.x
branch I will later addPathProvider
toMessagingBinders
when agreed to make it part of JAX-RS 4.1.