Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jakarta.faces.visit.SKIP_ITERATION #5355

Closed
BalusC opened this issue Nov 13, 2023 · 0 comments
Closed

Remove jakarta.faces.visit.SKIP_ITERATION #5355

BalusC opened this issue Nov 13, 2023 · 0 comments

Comments

@BalusC
Copy link
Contributor

BalusC commented Nov 13, 2023

Discovered while looking at jakartaee/faces#1853

RestoreViewPhase has this since JSF 2.0:

// PENDING: This is included for those component frameworks that don't utilize the
// new VisitHint(s) yet - but still wish to know that they should be non-iterating
// during state saving. It should be removed at some point.
facesContext.getAttributes().put(SKIP_ITERATION_HINT, true);

It has been superseded by https://jakarta.ee/specifications/platform/10/apidocs/jakarta/faces/component/visit/visithint. It's time to remove it. It can be done safely, it's nowhere documented in spec.

Its original value is javax.faces.visit.SKIP_ITERATION and it has since 3.0 even been renamed to jakarta.faces.visit.SKIP_ITERATION without being removed.

@BalusC BalusC added this to the 4.0.6 milestone Nov 26, 2023
BalusC added a commit that referenced this issue Dec 2, 2023
BalusC added a commit that referenced this issue Dec 2, 2023
@BalusC BalusC closed this as completed Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants