Don't use deprecated junit.framework.Assert #5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emil Sierżęga <emilsierzega@gmail.com>
melloware
approved these changes
Jun 16, 2022
arjantijms
approved these changes
Jun 16, 2022
|
Do I need to do anything else? Do I need to rebase my changes? |
|
Nope they will merge it when they get to it! |
|
@Emkas Thanks again, we're a bit on a rotating schedule with Mojarra and several other projects like GlassFish, so sometimes it may take a few days to look at a PR ;) |
|
@arjantijms Sure, no pressure from me :-) Just like I said in a different PR, I made several changes and not all of them can be easily separated. So now I'm waiting for merge of current ones and after that I'll bomb you with another :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.