Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5120: no need to doublecheck if view exists when invoked via ViewHandler#deriveLogicalViewId() instead of deriveViewId() #5121

Merged
merged 2 commits into from
Jun 19, 2022
Merged

Fix #5120: no need to doublecheck if view exists when invoked via ViewHandler#deriveLogicalViewId() instead of deriveViewId() #5121

merged 2 commits into from
Jun 19, 2022

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Jun 19, 2022

BalusC and others added 2 commits June 19, 2022 15:15
@arjantijms arjantijms added the 4.0 label Jun 19, 2022
@arjantijms arjantijms merged commit 17999cc into master Jun 19, 2022
@arjantijms arjantijms added this to the 4.0.1 milestone Jun 19, 2022
@BalusC BalusC deleted the mojarra_issue_5120 branch June 26, 2022 12:31
@arjantijms arjantijms mentioned this pull request Mar 14, 2023
Closed
arjantijms added a commit to arjantijms/mojarra that referenced this pull request Mar 14, 2023
@arjantijms
Fix for derivePhysicalViewId broken in eclipse-ee4j#5120
361fdc0 
This fixes the TCK failure introduced by issue eclipse-ee4j#5120 and pr eclipse-ee4j#5121

Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
@arjantijms arjantijms mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

Assignees
No one assigned
Labels
4.0
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@BalusC @arjantijms