Add back id attribute to VDL of h:head and h:body #5186
Conversation
…f h:head and h:body - fix HeadRenderer to only output it when actually specified - fix BodyRenderer to only output it when HTML5 doctype is used"" This reverts commit baf7998.
Fix failing BodyRendererTest
HeadRenderer encodeBegin complexity was already removed since introduction of new Doctype interface, so it can now be tested
|
Ran entire tck localhost as well, all green. |
|
Thomas can you review at least the spec change in taglib? https://github.com/eclipse-ee4j/mojarra/pull/5186/files#diff-a977313af2132f4b6dc25adc6bd8719a6822c5ae62ef547d1d7d82bbdc0baab3 Importantingly whether the wording "The attribute is only rendered when the current doctype is a HTML5 doctype" is clear enough for MyFaces to do the same. |
|
@tandraschko can you please review? |
|
I know he is on holiday but i think he is back sometime next week. |
|
@BalusC i wonder why this was removed in general? In MyFaces it looks like we always render the head/body id if specified by the user, doent matter if html5 or not. Thats sounds correct to me. |
|
It was accidentally removed, see also jakartaee/faces#1760 (comment) |
|
Ok I've inferred your comment as approval, Thomas. Hereby merged! :) |
jakartaee/faces#1760