Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mojarra issue 5190 merged into 4 0 #5193

Merged
merged 3 commits into from
Dec 17, 2022
Merged

Mojarra issue 5190 merged into 4 0 #5193

merged 3 commits into from
Dec 17, 2022

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Dec 17, 2022

@arjantijms arjantijms added the 4.0 label Dec 17, 2022
@arjantijms arjantijms added this to the 4.0.1 milestone Dec 17, 2022
@arjantijms arjantijms merged commit af05ede into 4.0 Dec 17, 2022
@arjantijms arjantijms deleted the mojarra_issue_5190_merged_into_4-0 branch December 17, 2022 12:46
@pizzi80
Copy link
Contributor

pizzi80 commented Dec 19, 2022

I had to use the following check inside EmptyStringToNullELResolver

if (    value == null &&
                String.class == targetType &&
                context instanceof org.apache.el.lang.EvaluationContext
    ) {

otherwise EL produce NPE during String concat,
for example:

#{'hello'.concat(null)}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
4.0
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@BalusC @pizzi80 @arjantijms