View maps entries are not restored in "finally" block #5234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MetadataImpl.createMetadataView"
|
Can you the next time please target exactly the branch of the version you want to see this fixed in? This PR is currently targeting master instead of 4.0 where the first occurrence of the bug is. |
|
@arjantijms FYI: this was thus a regression introduced in ebf6a08#diff-c73ecc7df840224c9e86287fdc64900a282fa24f60a2da13d3606d140572a2dfL102 I'll assume that this was just an oversight and thus not intentional. |
BalusC
approved these changes
May 20, 2023
|
Cherry picked for 4.0 via 40b8441 |
|
All good now. Thank you very much for creating the PR and improving Mojarra! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View maps entries are not restored in "finally" block of method "ViewMetadataImpl.createMetadataView" because "currentViewMapShallowCopy" is always empty