Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faces.js: isAutoExec test is not needed anymore #5267

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

pizzi80
Copy link
Contributor

@pizzi80 pizzi80 commented Jun 22, 2023

Replacing DOM element's innerHTML does not execute the (eventually) injected javascript.
This is standard, and we don't need to do this test anymore.

I'll leave the function only as a placeholder to identify the places where it is used in the code.

In the future a new and unique DOM replacement algorithm will replace the current functions,
and it will be possible to remove the isAutoExec() function as well

…false

Signed-off-by: pizzi80 <paolo@given2.com>
@BalusC
Copy link
Contributor

BalusC commented Jun 24, 2023

+1

@BalusC BalusC merged commit 523b021 into eclipse-ee4j:master Jun 24, 2023
@arjantijms arjantijms added the 5.0 label Jul 6, 2023
@pizzi80 pizzi80 deleted the 4.1.0_faces_js branch July 12, 2023 13:38
@BalusC BalusC added 4.1 and removed 5.0 labels Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants