Add context param attributes to @FacesConfig #5328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'origin/faces_issue_1830-remove_deprecated_things' into faces-config
to new FacesConfig.ContextParam API
param but old code still uses String
context params cannot start with / but the originally used default values actually started with / ... In order to not make it more complicated, let it be String instead of Path for now
annotation attribute, if any
java.lang.IllegalStateException: Unable to locate CDIProvider
and fixed ELUtilsTest failing due to BeanManager now being required before ApplicationImpl is created (as it needs context params which now checks FacesConfig annotation via CDI)
optimzed where possible
This was referenced Oct 14, 2023
context params now trying to search @FacesConfig CDI qualifier
|
Squashed into #5344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jakartaee/faces#1416
Just a step further to reduce web.xml usage.