Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for the Jakarta EE 11 M1 release #5373

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

arjantijms
Copy link
Contributor

Update dependencies to their M1 versions where applicable, and update code to support this.

Set release target to JDK 17, and removed some resulting warnings.

Update dependencies to their M1 versions where applicable, and update
code to support this.

Set release target to JDK 17, and removed some resulting warnings.

Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
@arjantijms arjantijms added the 4.1 label Dec 11, 2023
@arjantijms arjantijms added this to the 4.1.0 milestone Dec 11, 2023
@arjantijms arjantijms self-assigned this Dec 11, 2023
@arjantijms
Copy link
Contributor Author

PR will be updated with expressly M1 once it's available.

Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
@pzygielo
Copy link
Contributor

https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#release - it's recognized since plugin 3.6, but apparently no explicit version of m-compiler-p is specified and it depends on maven used and falls-back to 3.1 here.

Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
@arjantijms
Copy link
Contributor Author

https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#release - it's recognized since plugin 3.6, but apparently no explicit version of m-compiler-p is specified and it depends on maven used and falls-back to 3.1 here.

I thought, but clearly wrongly, that the compiler version came from the EE4J pom. But seems I was mistaken.

Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
@arjantijms
Copy link
Contributor Author

arjantijms commented Dec 11, 2023

https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#release - it's recognized since plugin 3.6, but apparently no explicit version of m-compiler-p is specified and it depends on maven used and falls-back to 3.1 here.

I also thought this would set the correct version of the compiler of Maven 3.6.0, but also seemingly it does not actually do that. Probably need to upgrade the minimal Maven version a bit to that which has Maven compiler 3.6 at least.

            <!-- Sets minimal Maven version to 3.6.0 -->
            <plugin>
                <artifactId>maven-enforcer-plugin</artifactId>
                <executions>
                    <execution>
                        <id>enforce-maven</id>
                        <goals>
                            <goal>enforce</goal>
                        </goals>
                        <configuration>
                            <rules>
                                <requireMavenVersion>
                                    <version>3.6.0</version>
                                </requireMavenVersion>
                            </rules>
                        </configuration>
                    </execution>
                </executions>
            </plugin>

@pzygielo
Copy link
Contributor

I also thought this would set the correct version of the compiler of Maven 3.6.0, but also seemingly it does not actually do that. Probably need to upgrade the minimal Maven version a bit to that which has Maven compiler 3.6 at least.

That would be maven 3.9.0, as all previous have m-c-p at 3.1.

Note: the current GH runner ubuntu-latest provides maven 3.8.8 only.

@arjantijms
Copy link
Contributor Author

Note: the current GH runner ubuntu-latest provides maven 3.8.8 only.

Thanks! So for now that is not really an option. Okay, let's think about setting minimum maven to 3.8.8 then, and additionally stil setting the compiler to the latest version.

@arjantijms arjantijms merged commit 92baa2d into eclipse-ee4j:4.1 Dec 11, 2023
2 checks passed
@arjantijms arjantijms deleted the 4.1-M1-prepare branch December 11, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants