Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5445 Dynamic actions not correctly processed #5446

Merged
merged 2 commits into from
May 26, 2024
Merged

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented May 18, 2024

Fix #5445: problem was two-fold:

  • UIData#invokeOnComponent shouldn't have skipped non-UIColumn kids
  • A FacesException while trying to locate dynamic component should not have blocked the view build time

- UIData#invokeOnComponent shouldn't have skipped non-UIColumn kids
- A FacesException while trying to locate dynamic component should not
have blocked the view build time
@BalusC BalusC requested review from arjantijms and mnriem May 18, 2024 13:44
@BalusC
Copy link
Contributor Author

BalusC commented May 18, 2024

I want to run TCK on this as well so wait with merge.

Copy link
Contributor

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@BalusC
Copy link
Contributor Author

BalusC commented May 18, 2024

TCK passed for me so it's OK to merge.

@BalusC BalusC merged commit 4a6bac3 into 4.0 May 26, 2024
3 checks passed
@BalusC BalusC added this to the 4.0.8 milestone May 26, 2024
@BalusC BalusC deleted the mojarra_issue_5445 branch May 26, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants