Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Huge demo jars #52

Closed
jbescos opened this issue Mar 18, 2022 · 1 comment · Fixed by #63
Closed

Huge demo jars #52

jbescos opened this issue Mar 18, 2022 · 1 comment · Fixed by #63

Comments

@jbescos
Copy link
Member

jbescos commented Mar 18, 2022

Compilation under parsson/demos//target/classes/META-INF contains all the content of parsson/demos/.

For example:

parsson$ ll demos/rest/target/classes/META-INF/
total 44
drwxrwxr-x 10 jbescos jbescos 4096 Mar 18 11:46 ./
drwxrwxr-x  3 jbescos jbescos 4096 Mar 18 11:46 ../
-rw-rw-r--  1 jbescos jbescos  368 Mar 18 11:46 .project
drwxrwxr-x  2 jbescos jbescos 4096 Mar 18 11:46 .settings/
drwxrwxr-x  5 jbescos jbescos 4096 Mar 18 11:46 customprovider-jdk9/
drwxrwxr-x  5 jbescos jbescos 4096 Mar 18 11:46 facebook/
drwxrwxr-x  5 jbescos jbescos 4096 Mar 18 11:46 jsonpointer/
drwxrwxr-x  5 jbescos jbescos 4096 Mar 18 11:46 rest/
drwxrwxr-x  4 jbescos jbescos 4096 Mar 18 11:46 servlet/
drwxrwxr-x  4 jbescos jbescos 4096 Mar 18 11:46 target/
drwxrwxr-x  5 jbescos jbescos 4096 Mar 18 11:46 twitter/

This generates demo jars of 3GB, because next demo compilation contains previous demo compilation files.

That is wrong. META-INF should only contain some meta files, but not sources, jars, etc
jbescos added a commit to jbescos/parsson that referenced this issue Mar 18, 2022
@jbescos
Huge demo jars eclipse-ee4j#52
785d360 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos jbescos mentioned this issue Mar 18, 2022
Merged
jbescos added a commit that referenced this issue Mar 21, 2022
@jbescos
Merge pull request #53 from jbescos/issue52
44ff34f 
Huge demo jars #52
@jbescos
Copy link
Member Author

jbescos commented Apr 6, 2022

Merged

@jbescos jbescos closed this as completed Apr 6, 2022
lukasj pushed a commit to lukasj/parsson that referenced this issue Jun 17, 2022
@jbescos @lukasj
Huge demo jars eclipse-ee4j#52
78476b9 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
(cherry picked from commit 785d360)
@lukasj lukasj linked a pull request Jun 17, 2022 that will close this issue
backports from master #63
Merged
lukasj pushed a commit that referenced this issue Jun 17, 2022
@jbescos @lukasj
Huge demo jars #52
161a55b 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
(cherry picked from commit 785d360)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backports from master lukasj/parsson
1 participant
@jbescos