Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EOL] Fix incorrect import failure reason #143

Merged

Conversation

Arkaedan
Copy link
Contributor

Fixes issue where parse problem is reported as "File ... contains errors: []" when the file is not found and "File ... not found" when there are parse problems

@agarciadom
Copy link
Contributor

agarciadom commented Dec 18, 2024

Oops! Thanks for identifying this. I'll make a note to add tests to catch this mistake in the future.

@agarciadom agarciadom merged commit 3092361 into eclipse-epsilon:main Dec 18, 2024
4 checks passed
agarciadom added a commit that referenced this pull request Dec 19, 2024
This is a follow-up from #143, which was fixing an issue that we
did not detect due to not having tests to check how we report
errors in imports.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants