Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProductFile should extract the locating of the instance area to a method to allow overrides by extenders #100

Closed
laeubi opened this issue Jul 4, 2022 · 0 comments · Fixed by #199
Closed

ProductFile should extract the locating of the instance area to a method to allow overrides by extenders #100

laeubi opened this issue Jul 4, 2022 · 0 comments · Fixed by #199

Comments

@laeubi
Copy link
Member

laeubi commented Jul 4, 2022

org.eclipse.equinox.internal.p2.publisher.eclipse.ProductFile currently uses

Location instanceLocation = ServiceHelper.getService(Activator.getContext(), Location.class, Location.INSTANCE_FILTER);

this obviously fails outside of OSGi as the BC is null.

One way would be to extract it into a protected method so extenders like Tycho can override and provide alternative locations or to check that the BC is actually not null...
@laeubi laeubi mentioned this issue Jul 4, 2022
Merged
laeubi added a commit to laeubi/p2 that referenced this issue Jul 20, 2022
@laeubi
Add consistent null checks to ServiceHelper
974b4d0 
currently only half of the methods do a null check for the bundle
context the other simply run ino a NPE. This adds the missing checks,
see also eclipse-equinox#100
laeubi added a commit to laeubi/p2 that referenced this issue Jul 20, 2022
@laeubi
Add consistent null checks to ServiceHelper
427c8af 
currently only half of the methods do a null check for the bundle
context the other simply run ino a NPE. This adds the missing checks,
see also eclipse-equinox#100
@laeubi laeubi mentioned this issue Jul 20, 2022
Merged
laeubi added a commit to laeubi/p2 that referenced this issue Jul 20, 2022
@laeubi
Add consistent null checks to ServiceHelper
3894c04 
currently only half of the methods do a null check for the bundle
context the other simply run into a NPE. This adds the missing checks,
see also eclipse-equinox#100
mickaelistria pushed a commit that referenced this issue Aug 5, 2022
@laeubi @mickaelistria
Add consistent null checks to ServiceHelper
0ff034b 
currently only half of the methods do a null check for the bundle
context the other simply run into a NPE. This adds the missing checks,
see also #100
laeubi added a commit to laeubi/p2 that referenced this issue Dec 4, 2022
@laeubi
ProductFile should extract the locating of the instance area to a method
9022ba2 
to allow overrides by extenders

Fix eclipse-equinox#100
@laeubi laeubi mentioned this issue Dec 4, 2022
Merged
akurtakov pushed a commit to laeubi/p2 that referenced this issue Dec 12, 2022
@laeubi @akurtakov
ProductFile should extract the locating of the instance area to a method
6318f06 
to allow overrides by extenders

Fix eclipse-equinox#100
laeubi added a commit to laeubi/p2 that referenced this issue Dec 13, 2022
@laeubi
ProductFile should extract the locating of the instance area to a method
d098efe 
to allow overrides by extenders

Fix eclipse-equinox#100
laeubi added a commit that referenced this issue Dec 14, 2022
@laeubi
ProductFile should extract the locating of the instance area to a method
55bc99b 
to allow overrides by extenders

Fix #100
laeubi added a commit to laeubi/tycho that referenced this issue Sep 8, 2024
@laeubi
Remove workaround for fixed P2 bug
d21d66e 
Currently we have a workaround for P2 bug
eclipse-equinox/p2#100 but the method is now
there and could be used.
@laeubi laeubi mentioned this issue Sep 8, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@laeubi