Ignore packed artifacts when parsing #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I prefer to land this for M1 but I'm open to the idea of pushing it now if people consider it very important fix. @tjwatson wdyt? |
Test Results 6 files ± 0 6 suites ±0 41m 34s ⏱️ + 14m 50s For more details on these failures, see this check. Results for commit 43cca01. ± Comparison against base commit 519e6b0. This pull request removes 117 tests.♻️ This comment has been updated with latest results. |
akurtakov
force-pushed
the
master
branch
2 times, most recently
from
65d6514
to
0a33e1d
Compare
Prevents issues when packed artifacts are returned by iterator but they can no longer be handled. Fixes eclipse-equinox#308
That way actually returned statuses are tested.
It was useless since pack200 support was removed but didn't fail as packed artifacts were not ignored entirely (at parsing time)
akurtakov
force-pushed
the
master
branch
4 times, most recently
from
e17ed76
to
e01dbff
Compare
|
Jenkins succeeded and I didn't retrigger GH actions. |
HannesWell
added a commit
to HannesWell/tycho
that referenced
this pull request
Dec 6, 2023
Eclipse P2 got its support for loading pack.gz packed artifacts from repositories finally removed in eclipse-equinox/p2#310. In order to fix the tests, remove packed duplicates from and replace only packed ecf artifact with unpacked eclipse.core.runtime artifact in test repository at '\resources\repositories\packgz'
This was referenced Dec 6, 2023
Merged
HannesWell
added a commit
to HannesWell/tycho
that referenced
this pull request
Dec 6, 2023
Eclipse P2 got its support for loading pack.gz packed artifacts from repositories finally removed in eclipse-equinox/p2#310. In order to fix the tests, remove packed duplicates from and replace only packed ecf artifact with unpacked eclipse.core.runtime artifact in test repository at '\resources\repositories\packgz'
akurtakov
pushed a commit
to HannesWell/tycho
that referenced
this pull request
Dec 7, 2023
Eclipse P2 got its support for loading pack.gz packed artifacts from repositories finally removed in eclipse-equinox/p2#310. In order to fix the tests, remove packed duplicates from and replace only packed ecf artifact with unpacked eclipse.core.runtime artifact in test repository at '\resources\repositories\packgz'
HannesWell
added a commit
to HannesWell/tycho
that referenced
this pull request
Dec 9, 2023
Eclipse P2 got its support for loading pack.gz packed artifacts from repositories finally removed in eclipse-equinox/p2#310. In order to fix the tests, remove packed duplicates from and replace only packed ecf artifact with unpacked eclipse.core.runtime artifact in test repository at '\resources\repositories\packgz'.
HannesWell
added a commit
to eclipse-tycho/tycho
that referenced
this pull request
Dec 9, 2023
Eclipse P2 got its support for loading pack.gz packed artifacts from repositories finally removed in eclipse-equinox/p2#310. In order to fix the tests, remove packed duplicates from and replace only packed ecf artifact with unpacked eclipse.core.runtime artifact in test repository at '\resources\repositories\packgz'.
github-actions bot
pushed a commit
to eclipse-tycho/tycho
that referenced
this pull request
Dec 9, 2023
Eclipse P2 got its support for loading pack.gz packed artifacts from repositories finally removed in eclipse-equinox/p2#310. In order to fix the tests, remove packed duplicates from and replace only packed ecf artifact with unpacked eclipse.core.runtime artifact in test repository at '\resources\repositories\packgz'. (cherry picked from commit da254b3)
HannesWell
added a commit
to eclipse-tycho/tycho
that referenced
this pull request
Dec 9, 2023
Eclipse P2 got its support for loading pack.gz packed artifacts from repositories finally removed in eclipse-equinox/p2#310. In order to fix the tests, remove packed duplicates from and replace only packed ecf artifact with unpacked eclipse.core.runtime artifact in test repository at '\resources\repositories\packgz'. (cherry picked from commit da254b3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents issues when packed artifacts are returned by iterator but they can no longer be handled.
Fixes #308