Nullpointer in AbstractRepositoryManager#handleRemoteIndexFile #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that in some rare cases the handleRemoteIndexFile could run into a NPE if the Transport service can't be fetched. This now checks first for null before using the transport and if it is null fall back to simple URL stream, if that also fails, create an empty index file.
|
It seems the issue is/was the ECF bundles where missing in my run config .... so I'm not sure if my fix still applies here but P2 could use a fallback service for Transports that simply uses URL.openStream even though this might not be very powerful its better than failing completely. |
merks
reviewed
Feb 27, 2024
| if (indexFileStatus != null && indexFileStatus.isOK()) | ||
| return LocationProperties.create(new ByteArrayInputStream(index.toByteArray())); | ||
| } else { | ||
| try (InputStream openStream = indexFileURI.toURL().openStream()) { |
There was a problem hiding this comment.
My big concern here is that this masks a severe configuration problem. A problem likely to crop up elsewhere and a problem that, if not fixed will, will disable all kinds of functionality such as proxy support. Surely if one gets the index, something downstream will fail instead.
It would seem better to fail with some kind of message about the transport not being configured available and the like cause(s) for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that in some rare cases the handleRemoteIndexFile could run into a NPE if the Transport service can't be fetched.
This now checks first for null before using the transport and if it is null fall back to simple URL stream, if that also fails, create an empty index file.
@merks I don't know how this could happen but seen this in a log while performing an update operation, but the method itself also seems merely used (only found two references), so instead of running into a NPE this seems better and hopefully then reveals the real root cause later on.
The stacktrace is: