-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add flywaydb postgre dependency #2024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @samos667 for taking the time to contribute to hawkBit! We really appreciate this. Make yourself comfortable while I'm looking for a committer to help you with your contribution.
Please make sure you read the contribution guide and signed the Eclipse Contributor Agreement (ECA).
Quality Gate passedIssues Measures |
Can one of the admins verify this patch? |
Hi @samos667, we could not accept your contribution because you haven't signed ECA, @see the failed check. Then I wonder if we shall add flyway optional dependencies in into hawkbit-repository-jpa. Could you share more about how are you using hawkbit? |
Hi @avgustinmm Sorry I didn't see about ECA. We use docker image for now. We started using it at 0.5.0 with postgre 16.4. But when trying to upgrade, when using hawkbit-server image 0.6.1, there is flyway error about postgre version but this a about postgre usage itself and seems related to flyway deps declaration. Is there a way to easily enable postgre support for docker images ? Edit:
There is not database connector on standard image, so we need to build some kind of postgre image by yourself, right ? |
Hi, For now, to make 0.6.1 work with PostgreSQL you could create a docker image with flyway-database-postgresql by yourself. There are two easy ways I see:
|
Thanks for the info, I really appreciate it ! We'll build our postgre image from the official one, that's the best option at the moment. So I will close this PR as I think my change is not the way. And I'm not really sure (as a deploy manager) how to do it right. |
Since 0.6.1, hawkbit with postgre is not yet support if not specified it in dependency flyway/flyway#3909 (comment)
We only have postgre databases in our infra and we will want to keep it that way.
Thanks in advance !