Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maksimchepelev/fetaure cli validation ENG-546 #530

Merged
merged 4 commits into from
Feb 7, 2019
Merged

Maksimchepelev/fetaure cli validation ENG-546 #530

merged 4 commits into from
Feb 7, 2019

Commits on Feb 6, 2019

  1. feat(cli): add correct validation for cli 

    + args parsing using Mar of <arg, values>
+ throw error if value for number arg not provided or string was provided:
    `--number_arg string` or `--number_arg`
- validation of number type (integer/float) because there is no info about type in help
    @mchepelev
    mchepelev committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    263610a View commit details
    Browse the repository at this point in the history

  2. feat(cli): add correct validation for cli 

    +  float/integer validation
+- number -> float/integer in cli help
    @mchepelev
    mchepelev committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    73efbc5 View commit details
    Browse the repository at this point in the history

  3. feat(cli): add correct validation for cli 

    +- correct regexp for parsing cli
    @mchepelev
    mchepelev committed Feb 6, 2019
    Configuration menu
    Copy the full SHA
    44512dc View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. feat(cli): add correct validation for cli 

    +- correct Integer and Float types
+- fix some problems

Closes ENG-621
    @mchepelev
    mchepelev committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    583b331 View commit details
    Browse the repository at this point in the history