Handle the StringConcatFactory invocation with 200+ arguments #1164 #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be applied on top or PR #1139. We only need the last commit from here. Rest of them are already on the said PR. |
3 tasks
|
@srikanth-sankaran In the interest of getting this tested enough, I will release this change (also expecting the new fail-fast approach help me here). You are welcome to review this whenever you find time. |
|
This needs to wait. I see that the stack size goes up for all aload of the operands, but never removed when we consume them by a makeConcatWithConstants. Working on a fix. |
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this pull request
Jul 18, 2024
…e-jdt#1172) When we have too many operands in a String concat expression, the StringConcatFactory hits the 200 arguments limit and crashes. To avoid this, we wrap every 190 arguments into a StringConcatFactory#makeConcatWithConstants() instead of keeping them in the stack. This way, we can accommodate thousands of operands (to be precise 190x199) before hitting the limit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes issue #1164
How to test
Author checklist