CombinedBinaryExpression.buildStringForConcatation() produces unexpected #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytecode - additionally to the actual fix and test added StringConcatTest to the test suite (that was forgotten to be added before). Fixes eclipse-jdt#1201
|
Note: PR fails because of 3 failing tests from #1201, and they will be only fixed after we've built tests with the fixed compiler, but to do that we have to deploy compiler first that is used to build tests. |
3 tasks
jarthana
approved these changes
Jul 2, 2023
|
I confirm that the fix is what the original fix should have been. I have also verified that the tests fail locally on the latest build but fail when the build is patched with this PR. |
mpalat
pushed a commit
to mpalat/eclipse.jdt.core
that referenced
this pull request
Jul 6, 2023
…ted (eclipse-jdt#1202) bytecode - additionally to the actual fix and test added StringConcatTest to the test suite (that was forgotten to be added before). Fixes eclipse-jdt#1201
robstryker
pushed a commit
to robstryker/eclipse.jdt.core
that referenced
this pull request
Jul 18, 2024
…ted (eclipse-jdt#1202) bytecode - additionally to the actual fix and test added StringConcatTest to the test suite (that was forgotten to be added before). Fixes eclipse-jdt#1201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bytecode
Fixes #1201