Incorrect startPosition of a SingleVariableDeclaration in the catch block #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subyssurendran666
force-pushed
the
incorrect-startPosition-of-a-SingleVariableDeclaration-in-the-catch-block
branch
2 times, most recently
from
9b73834
to
e45dec2
Compare
jarthana
requested changes
Sep 23, 2024
org.eclipse.jdt.core/model/org/eclipse/jdt/internal/core/util/CommentRecorderParser.java
Show resolved
Hide resolved
org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/dom/ASTConverter18Test.java
Outdated
Show resolved
Hide resolved
subyssurendran666
force-pushed
the
incorrect-startPosition-of-a-SingleVariableDeclaration-in-the-catch-block
branch
2 times, most recently
from
9ceb866
to
dd6a1bb
Compare
subyssurendran666
force-pushed
the
incorrect-startPosition-of-a-SingleVariableDeclaration-in-the-catch-block
branch
2 times, most recently
from
df3f8ba
to
8cb4db4
Compare
|
@subyssurendran666 Sorry for input in a piecemeal manner. Can you also add a testcase with a comment on the catch parameter? Like this: |
subyssurendran666
force-pushed
the
incorrect-startPosition-of-a-SingleVariableDeclaration-in-the-catch-block
branch
from
8cb4db4
to
98533cf
Compare
@jarthana I have added a new test case. Could you please review my changes ? |
jarthana
approved these changes
Sep 26, 2024
subyssurendran666
force-pushed
the
incorrect-startPosition-of-a-SingleVariableDeclaration-in-the-catch-block
branch
from
98533cf
to
8d66756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
#2564
How to test
Author checklist