use Path.of() to avoid 'Potential resource leak' warnings

eclipse-jdtls · Jan 9, 2024 · 67fce40 · 67fce40
1 parent 63ad336
commit 67fce40
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 10 deletions.
diff --git a/...t.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/batch/ClasspathDirectory.java b/...t.core.compiler.batch/src/org/eclipse/jdt/internal/compiler/batch/ClasspathDirectory.java
@@ -39,7 +39,6 @@
 import java.io.File;
 import java.io.FilenameFilter;
 import java.io.IOException;
-import java.nio.file.FileSystems;
 import java.nio.file.FileVisitResult;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -345,7 +344,7 @@ public boolean hasCUDeclaringPackage(String qualifiedPackageName, Function<Compi
 public char[][] listPackages() {
 	Set<String> packageNames = new HashSet<>();
 	try {
-		Path basePath = FileSystems.getDefault().getPath(this.path);
+		Path basePath = Path.of(this.path);
 		Files.walkFileTree(basePath, new SimpleFileVisitor<Path>() {
 			@Override
 			public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) {

diff --git a/...re.compiler.batch/src/org/eclipse/jdt/internal/compiler/parser/AbstractCommentParser.java b/...re.compiler.batch/src/org/eclipse/jdt/internal/compiler/parser/AbstractCommentParser.java
@@ -16,7 +16,6 @@
 import static org.eclipse.jdt.internal.compiler.parser.TerminalTokens.TokenNameEOF;
 
 import java.io.IOException;
-import java.nio.file.FileSystems;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.ArrayDeque;
@@ -1788,7 +1787,7 @@ private Path getFilePathFromFileName(String fileName) {
 		ArrayList<String> sourceClassPaths = (ArrayList<String>) this.srcClasspath;
 		Path filePath = null;
 		for (String iPath : sourceClassPaths) {
-			filePath = FileSystems.getDefault().getPath(this.projectPath, iPath, fileName);
+			filePath = Path.of(this.projectPath, iPath, fileName);
 			if(filePath.toFile().exists())
 				break;
 		}

diff --git a/...sts.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/JavadocTestForModule.java b/...sts.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/JavadocTestForModule.java
@@ -19,7 +19,6 @@
 import java.io.FileWriter;
 import java.io.IOException;
 import java.nio.file.DirectoryNotEmptyException;
-import java.nio.file.FileSystems;
 import java.nio.file.FileVisitResult;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -322,7 +321,7 @@ private void walkOutFiles(final String outputLocation, final Set<String> fileNam
 		if (!(new File(outputLocation)).exists())
 			return;
 		try {
-			Files.walkFileTree(FileSystems.getDefault().getPath(outputLocation), new SimpleFileVisitor<Path>() {
+			Files.walkFileTree(Path.of(outputLocation), new SimpleFileVisitor<Path>() {
 				@Override
 				public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IOException {
 					if (file.toString().endsWith(".class")) {

diff --git a/...s.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/ModuleCompilationTests.java b/...s.compiler/src/org/eclipse/jdt/core/tests/compiler/regression/ModuleCompilationTests.java
@@ -18,7 +18,6 @@
 import java.io.FileWriter;
 import java.io.IOException;
 import java.nio.file.DirectoryNotEmptyException;
-import java.nio.file.FileSystems;
 import java.nio.file.FileVisitResult;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -328,7 +327,7 @@ private void walkOutFiles(final String outputLocation, final Set<String> fileNam
 		if (!(new File(outputLocation)).exists())
 			return;
 		try {
-			Files.walkFileTree(FileSystems.getDefault().getPath(outputLocation), new SimpleFileVisitor<Path>() {
+			Files.walkFileTree(Path.of(outputLocation), new SimpleFileVisitor<Path>() {
 				@Override
 				public FileVisitResult visitFile(Path file, BasicFileAttributes attrs) throws IOException {
 					if (file.toString().endsWith(".class")) {

diff --git a/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/NameLookupTests2.java b/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/NameLookupTests2.java
@@ -15,7 +15,6 @@
 package org.eclipse.jdt.core.tests.model;
 
 import java.io.IOException;
-import java.nio.file.FileSystems;
 import java.nio.file.Files;
 
 import org.eclipse.core.resources.IWorkspaceRunnable;
@@ -362,7 +361,7 @@ public void testFindTypeWithUnrelatedWorkingCopy() throws Exception {
  */
 public void testTransitionFromInvalidToValidJar() throws CoreException, IOException {
 	String transitioningJar = getExternalPath() + "transitioningJar.jar";
-	java.nio.file.Path transitioningJarPath = FileSystems.getDefault().getPath(transitioningJar);
+	java.nio.file.Path transitioningJarPath = java.nio.file.Path.of(transitioningJar);
 	IPath transitioningIPath = Path.fromOSString(transitioningJar);
 
 	try {