Use resolved JavaElement from binding for CompletionContext.enclosing #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelistria
force-pushed
the
context-enclosing
branch
from
b301f79 to
89d0e62
Compare
|
Compared to baseline https://ci.eclipse.org/ls/job/jdt-core-incubator/job/dom-with-javac/710/ , this code seems to add 1 failure. Further investigation is necessary. |
datho7561
force-pushed
the
dom-with-javac
branch
from
aa3b08f to
cc0dccd
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
7e220b3 to
525cd23
Compare
mickaelistria
force-pushed
the
context-enclosing
branch
4 times, most recently
from
fa485d7 to
44f1a95
Compare
+ Adjust bindings to fix errors highlighted by tests
mickaelistria
force-pushed
the
context-enclosing
branch
from
44f1a95 to
0bef8be
Compare
mickaelistria
merged commit 0bef8be
into
eclipse-jdtls:dom-with-javac
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.