Constructor invocation completion proposal improvements #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use expected types to infer constructor type (instead of existing logic which duplicates the logic of expected types) - Use `IType` and `IMethod` when creating constructor invocation proposals, to avoid needing to create bindings - Handle suggesting the default constructor when an `IType` has no explicit constructors - Modify the content of the completion proposals to match what's expected by the tests Signed-off-by: David Thompson <davthomp@redhat.com>
|
8 new passing tests |
datho7561
deleted the
dom-with-javac-cic-completion-use-expected-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITypeandIMethodwhen creating constructor invocation proposals, to avoid needing to create bindingsITypehas no explicit constructors