Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for method parameter completions #396

Merged

Conversation

gayanper
Copy link

@gayanper gayanper commented May 17, 2024

This PR adds basic support for completing parameter names with basic parameter suggestion logic.

public class Main {
    public void foo(String ) {}
}

Complete after String

Copy link

@mickaelistria mickaelistria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please share an example of code this patch completes better? (to ensure I test the right thing ;)

@gayanper
Copy link
Author

@mickaelistria I added the snippet. The current names suggestion are just type name made camel case and combined with the token. No any smart logic is there for better naming

@mickaelistria
Copy link

Thanks!

@mickaelistria mickaelistria merged commit 643aea5 into eclipse-jdtls:dom-with-javac May 17, 2024
2 of 4 checks passed
@gayanper gayanper deleted the method-param-names branch May 17, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants