Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements to JavacBindingResolver #418

Merged
merged 1 commit into from
May 27, 2024
Merged

Some improvements to JavacBindingResolver #418

merged 1 commit into from
May 27, 2024

Conversation

mickaelistria
Copy link

  • resolveTypeBinding can work for primitiveType input, independently of whether they are used in the DOM
  • support resolveType for VariableDeclaration
  • support resolveConstructor(ConstructorInvocation invocation)
  • Fix failures with initializer (methodSymbol without type)
  • Fix constructor bindings names to better map legacy

@mickaelistria
Some improvements to JavacBindingResolver
85277fe 
* resolveTypeBinding can work for primitiveType input, independently of
whether they are used in the DOM
* support resolveType for VariableDeclaration
* support resolveConstructor(ConstructorInvocation invocation)
* Fix failures with initializer (methodSymbol without type)
* Fix constructor bindings names to better map legacy
@mickaelistria mickaelistria linked an issue May 27, 2024 that may be closed by this pull request
NPE in tests: Cannot invoke "com.sun.tools.javac.code.Type.getTypeArguments()" because "this.type" is null #414
Closed
@mickaelistria mickaelistria merged commit fe21918 into eclipse-jdtls:dom-with-javac May 27, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mickaelistria mickaelistria

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE in tests: Cannot invoke "com.sun.tools.javac.code.Type.getTypeArguments()" because "this.type" is null
1 participant
@mickaelistria