[Releng] Force qualifier to start with z
#435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akurtakov
reviewed
May 29, 2024
Jenkinsfile
Outdated
| @@ -67,7 +67,8 @@ pipeline { | |||
|
|
|||
| unset JAVA_TOOL_OPTIONS | |||
| unset _JAVA_OPTIONS | |||
| mvn install -DskipTests -Djava.io.tmpdir=$WORKSPACE/tmp | |||
| # force qualifier to start with `z` so we identify it more easily and it always seem more recent than upstrea | |||
| mvn install -DskipTests -Djava.io.tmpdir=$WORKSPACE/tmp -Dtycho.buildqualifier.format='z'yyyyMMdd-HHmm | |||
There was a problem hiding this comment.
I think you have to actually make it -Dtycho.buildqualifier.format="'z'yyyyMMdd-HHmm" to prevent shell from handling '' and thus having zyyyyMMdd-HHmm passed to java as z will make timezone printed.
mickaelistria
force-pushed
the
z-qualifier
branch
2 times, most recently
from
175d9be to
5dcb1b4
Compare
|
Build fails when doing baseline comparison because we now produce new artifacts (with |
mickaelistria
force-pushed
the
z-qualifier
branch
from
5dcb1b4 to
7def959
Compare
mickaelistria
merged commit e89f267
into
eclipse-jdtls:dom-with-javac
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #434