Flatten chains of InfixExpressions #436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's annoying: test0106 verifies that in some case, the optimization doesn't happen. |
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Fixes eclipse-jdt#180, fixes eclipse-jdt#206 Signed-off-by: David Thompson <davthomp@redhat.com>
Makes it not needed to manually add --add-opens to eclipse.ini after installing. PDE doesn't handle that so nested workbench still needs the params added to the launch configuration.
… call Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
+ move DOM-based selection and completion to codeassist package.
process more contents in JCError nodes
Fix some positions and others.
Honor the search pattern settings.
Signed-off-by: David Thompson <davthomp@redhat.com>
Closes eclipse-jdt#218 Signed-off-by: David Thompson <davthomp@redhat.com>
Closes eclipse-jdt#219 Signed-off-by: David Thompson <davthomp@redhat.com>
Signed-off-by: David Thompson <davthomp@redhat.com>
Signed-off-by: David Thompson <davthomp@redhat.com>
… to Javac compiler (eclipse-jdt#268)
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
* Add some toString to bindings * Some support for method receiver type * Some extra JLS version checks * Improve support for parameterized types and wildcards * add JavacBindingResolver.resolveAnnotation() * Resolve lambda to methodBindings
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Check for flags before converting enum constant
Signed-off-by: David Thompson <davthomp@redhat.com>
The implementation of this method works directly on a DOM and how the DOM was produced doesn't matter. So it doesn't have to be part of the interface.
mickaelistria
force-pushed
the
dom-with-javac
branch
from
4ba2fb1 to
8140623
Compare
These fixes will make the resolver handle NPEs when the code contains syntax errors.
When syntax errors exist in the code, the identifiers could be not valid, on such identifiers don't calculate the source range.
The offset reported for Javadoc comments for the access method we are currently using is almost always -1. By accessing the offset value directly reflexively, we can access the value we really want, the offset of the `/**` token, which is stored in a parent class as a private final field. Signed-off-by: David Thompson <davthomp@redhat.com>
The type annotation are now read from the typeSymbol as it has done for method annotations.
Signed-off-by: David Thompson <davthomp@redhat.com>
Signed-off-by: David Thompson <davthomp@redhat.com>
Signed-off-by: David Thompson <davthomp@redhat.com>
Use the TypeSymbol when available instead of toString to avoid TypeSignature creation failures due to toString could provide information in addition to what is expected by TypeSignature creation.
Rethrow the first throwable encountered Signed-off-by: David Thompson <davthomp@redhat.com>
Even if it's technically a field access, if all the segments are simple names without any class names, method invocations, or keywords, then it should be treated as a qualified name for the purpose of converting to the JDT AST. Signed-off-by: David Thompson <davthomp@redhat.com>
|
@mickaelistria what are your thoughts on merging this? Overall to me, it seems it reduces the number of dom conversion test failures. |
|
I'll rebase and see, but the fact that it's causing other failures is an annoyance I'd like to understand and fix. |
Signed-off-by: David Thompson <davthomp@redhat.com>
mickaelistria
force-pushed
the
flatten-infix
branch
from
2efc76d to
506c6e5
Compare
mickaelistria
force-pushed
the
flatten-infix
branch
from
506c6e5 to
4eff632
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
dd2c73d to
4c6a3af
Compare
|
Fixed by #497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #419