Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some tests #448

Merged

Conversation

mickaelistria
Copy link

  • Add some toString to bindings
  • Some support for method receiver type
  • Some extra JLS version checks

@mickaelistria mickaelistria force-pushed the morefixes branch 3 times, most recently from ba7ec0b to 740568a Compare June 4, 2024 18:25
Copy link

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this fixes a lot of test cases, I'm okay if this is merged, I'll wait on the main branch tests to make sure the failures are going down

@mickaelistria
Copy link
Author

Let's also rebase this one to ensure we compare comparable stuff.

* Add some toString to bindings
* Some support for method receiver type
* Some extra JLS version checks
* Improve support for parameterized types and wildcards
* add JavacBindingResolver.resolveAnnotation()
* Resolve lambda to methodBindings
@mickaelistria
Copy link
Author

Fixes 26 tests.

@mickaelistria mickaelistria merged commit d5c5552 into eclipse-jdtls:dom-with-javac Jun 4, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants