Prevent multiple errors from being reported at the same offset #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-jdt#320 Signed-off-by: David Thompson <davthomp@redhat.com>
mickaelistria
requested changes
Jun 4, 2024
There was a problem hiding this comment.
I don't think this fix is valid. It seems possible that 2 distinct error can be at the same location (for example 1 deprecation warning + 1 "not static member" on the same dereference.
This issue seems like a very particular case, while the proposed patch seems too general.
|
It seems from the documentation that our error reporter is expected to only report the first error reported at the office. Although, the offset reported by javac is different for these two errors. javac doesn't report both errors on the command line. I'll take another look into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #320