Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/workaround bindings for generics vs parameterized #694

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

mickaelistria
Copy link

No description provided.

@mickaelistria
Copy link
Author

New failures are caused by generic and parameterized sharing the same getKey(), while generic should only show the type parameter simple name in getKey and parameterized should show the qualified name of the type parameter (including defining class prefix).

@robstryker
Copy link

Right now the field in question (isDeclaration) is kinda insufficient. For example, a line of code that reads

if( myvar instanceof SomeType), SomeType is not a declaration, but it also is not related to a specific instance of SomeType, and so it must have a getName() that does not include any parameters or generics at all.

There's a lot of code here inter-relating with each other and it's hard to keep track of it all.

@robstryker
Copy link

Please don't merge or continue working on this. I have overlapping code that I'd been working on for two days. Next time just ping me to point to the specific test and we can discuss.

@mickaelistria mickaelistria force-pushed the gen-param branch 5 times, most recently from fea9e50 to 9d6c136 Compare August 14, 2024 13:02
@mickaelistria
Copy link
Author

I've seen some of your commits are contributing big parts of necessary fixes and cherry-picked some of them. But I'm going to continue working on this as I believe the current proposal fixes more things in a more reliable way.

@mickaelistria
Copy link
Author

This was updated after recent merge and this now shows a dozen of fixed tests compared to the "best" former state.

@mickaelistria mickaelistria merged commit 3cea766 into eclipse-jdtls:dom-with-javac Aug 14, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants