Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem range for IProblem.AbstractServiceImplementation #737

Conversation

datho7561
Copy link

@datho7561 datho7561 commented Aug 21, 2024

- progress is currently hampered by #729, I get a stacktrace that that PR should fix (classcast from within javac)

This PR used to contain way more fixes, but those have already been mostly merged.

Now it just fixes the problem range for IProblem.AbstractServiceImplementation.

This PR should introduce no new failures or passes in the test suite.

@datho7561 datho7561 marked this pull request as draft August 21, 2024 20:26
@mickaelistria mickaelistria force-pushed the dom-with-javac branch 2 times, most recently from 13a7ce9 to 911e4b3 Compare September 10, 2024 08:43
@mickaelistria mickaelistria force-pushed the dom-with-javac branch 3 times, most recently from 16bd705 to 9fb5696 Compare September 25, 2024 06:20
@datho7561 datho7561 force-pushed the dom-with-javac-more-module-problemids branch 3 times, most recently from 972a938 to 10656a9 Compare September 27, 2024 21:12
@datho7561 datho7561 force-pushed the dom-with-javac-more-module-problemids branch from 10656a9 to a8fa198 Compare November 21, 2024 14:10
Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 changed the title [WIP] some more module problem ids Problem range for IProblem.AbstractServiceImplementation Nov 21, 2024
@datho7561 datho7561 force-pushed the dom-with-javac-more-module-problemids branch from a8fa198 to 5ea7103 Compare November 21, 2024 14:19
@datho7561 datho7561 marked this pull request as ready for review November 21, 2024 14:20
@datho7561 datho7561 merged commit 911dd4e into eclipse-jdtls:dom-with-javac Nov 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant