Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly filter code actions according to context.only values #1112

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Properly filter code actions according to context.only values #1112

merged 1 commit into from
Jul 17, 2019
+62 −6

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Jul 17, 2019

See redhat-developer/vscode-java#986

Signed-off-by: Fred Bricon fbricon@gmail.com

@fbricon fbricon added this to the Mid July 2019 milestone Jul 17, 2019
@fbricon
Copy link
Contributor Author

fbricon commented Jul 17, 2019

Still need to look at the tests

@fbricon fbricon added the bug label Jul 17, 2019
@fbricon
Properly filter code actions according to context.only values
db5430b 
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon marked this pull request as ready for review July 17, 2019 12:32
@fbricon
Copy link
Contributor Author

fbricon commented Jul 17, 2019

Tests fixed

@fbricon fbricon merged commit febf189 into eclipse-jdtls:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snjeza snjeza snjeza approved these changes

@testforstephen testforstephen Awaiting requested review from testforstephen

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Mid July 2019
Development

Successfully merging this pull request may close these issues.
2 participants
@fbricon @snjeza