Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickFix for annotation missing attributes #2335

Merged

Conversation

datho7561
Copy link
Contributor

@datho7561 datho7561 commented Nov 18, 2022

Requires eclipse-jdt/eclipse.jdt.ui#335

Closes #1860

Signed-off-by: David Thompson davthomp@redhat.com

@eclipse-ls-bot
Copy link

Can one of the admins verify this patch?

@datho7561 datho7561 force-pushed the 1860-missing-annotation-attributes branch 2 times, most recently from 35a0be9 to ee94013 Compare December 8, 2022 19:04
@datho7561 datho7561 marked this pull request as ready for review December 8, 2022 20:08
Requires eclipse-jdt/eclipse.jdt.ui#335

Closes eclipse-jdtls#1806

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 force-pushed the 1860-missing-annotation-attributes branch from ee94013 to fa58379 Compare December 9, 2022 17:03
@datho7561
Copy link
Contributor Author

@rgrunber I added the tests, should be ready to review.

@rgrunber
Copy link
Contributor

rgrunber commented Dec 9, 2022

add to whitelist

@rgrunber rgrunber merged commit 7c7a064 into eclipse-jdtls:master Dec 9, 2022
@datho7561 datho7561 deleted the 1860-missing-annotation-attributes branch December 9, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeAction for missing required attribute
3 participants